Update mesh.js #5663
Closed
Update mesh.js #5663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix bug in getIndices which incorrectly modifies an array to have an array in the first element instead of setting the array to the numbers.
mvaligursky
reviewed
Sep 22, 2023
| @@ -723,7 +723,7 @@ class Mesh extends RefCountedObject { | |||
| } else { | |||
| // destination data is array | |||
| indices.length = 0; | |||
| indices.push(streamIndices); | |||
| indices.push(...streamIndices); | |||
There was a problem hiding this comment.
Nice, but lets avoid using spread operator here on these potentially larger arrays due to nodejs/node#16870
(We've had an experience in other code with this)
There was a problem hiding this comment.
Looks like a good-old for-loop would handle both cases equally here (untested assumption)
There was a problem hiding this comment.
@chrissterling - would you have time to do this change please?
Merged
|
Thanks for finding the issue and the fix, that was really helpful, we've merged slightly modified fix now, so I'm closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug in getIndices which incorrectly modifies an array to have an array in the first element instead of setting the array to the numbers.
Fixes #
I confirm I have read the contributing guidelines and signed the Contributor License Agreement.