Zero out setTimeout id #7023
Closed
Zero out setTimeout id #7023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe the case of canceling was necessary for WebXR, either during session creation, and/or during WebXR active session to avoid rendering to non-xr canvas while session is running. |
|
Actually the entire tick implementation needs a rewrite. Closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have noticed that
cancelAnimationFrameactually appears on performance captures in Chrome, but cancelling should be almost always unnecessary.In this PR I nullify the timeout id at the end of the update loop so cancelling is skipped during the next invocation.
I can't think of negative impact or side effect of this change, can you @Maksims ?