Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CameraFrame render pass rendering supports stencil buffer #7031

Merged
merged 2 commits into from
Oct 14, 2024
Merged

CameraFrame render pass rendering supports stencil buffer #7031

merged 2 commits into from
Oct 14, 2024

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Oct 14, 2024 •
edited
Loading

  • new stencil flag, which defaults to false
  • when stencil is used together with depth prepass, the prepass generated depth is not used during the main render pass to early depth-cull, as the depth buffer from the prepass might not correct due to prepass not handling stencil

@mvaligursky mvaligursky self-assigned this Oct 14, 2024
@mvaligursky mvaligursky added area: graphics Graphics related issue enhancement labels Oct 14, 2024
@mvaligursky mvaligursky requested a review from a team October 14, 2024 10:41
@mvaligursky mvaligursky merged commit d50705d into main Oct 14, 2024
8 checks passed
@mvaligursky mvaligursky deleted the mv-cameraframe-stencil branch October 14, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willeastcott willeastcott willeastcott approved these changes

@slimbuck slimbuck slimbuck approved these changes

Assignees

@mvaligursky mvaligursky

Labels
area: graphics Graphics related issue enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mvaligursky @willeastcott @slimbuck