-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop Java 8 #207
Drop Java 8 #207
Conversation
Omnidoc / javadoc / tastyFiles from Omnidoc / javadoc ((sbt.Defaults.docTaskSettings) Defaults.scala:2123) Omnidoc / compile / bspReporter from Omnidoc / javadoc ((sbt.Defaults.docTaskSettings) Defaults.scala:2123) Omnidoc / scaladoc / tastyFiles from Omnidoc / scaladoc ((sbt.Defaults.docTaskSettings) Defaults.scala:2123) Omnidoc / compile / bspReporter from Omnidoc / scaladoc ((sbt.Defaults.docTaskSettings) Defaults.scala:2123)
@@ -195,12 +180,14 @@ object OmnidocBuild { | |||
|
|||
def compilerReporterSettings = Seq( | |||
compile / compilerReporter := { | |||
new sbt.internal.server.LanguageServerReporter( | |||
new sbt.internal.inc.LoggedReporter( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This and the below tastyFiles / bspReporter hack allows us to finally upgrade to latest sbt version
maxErrors.value, | ||
streams.value.log, | ||
foldMappers(sourcePositionMappers.value) | ||
) | ||
}, | ||
tastyFiles := (Compile / compile / tastyFiles).value, // not 100% sure but it seems to work | ||
bspReporter := (Compile / compile / bspReporter).value, // same |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needed to fix (because of sbt upgrade)
References to undefined settings:
Omnidoc / javadoc / tastyFiles from Omnidoc / javadoc ((sbt.Defaults.docTaskSettings) Defaults.scala:2123)
Omnidoc / compile / bspReporter from Omnidoc / javadoc ((sbt.Defaults.docTaskSettings) Defaults.scala:2123)
Omnidoc / scaladoc / tastyFiles from Omnidoc / scaladoc ((sbt.Defaults.docTaskSettings) Defaults.scala:2123)
Omnidoc / compile / bspReporter from Omnidoc / scaladoc ((sbt.Defaults.docTaskSettings) Defaults.scala:2123)
Actually these two settings does not really matter in this context IMHO, bsp is for build server protocol and tastyFiles for Scala 3, but even if we use Scala 3 here, it should not really matter as well. I keep the comment here in case someone stumples over it and thinks this should be changed.
@@ -118,13 +117,17 @@ object OmnidocBuild { | |||
|
|||
def projectSettings: Seq[Setting[_]] = Seq( | |||
name := "play-omnidoc", | |||
version := playVersion, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switching to sbt-ci-release/sbt-dynver
So, I am going to merge this. It was a bit a pita to figure everything out.
and then compare both jar files in the For me this confirms this is working correctly. |
So another proof this worked correctly: |
No description provided.