Skip to content

Commit

Permalink
Merge pull request #227 from mkurz/play29M2
Browse files Browse the repository at this point in the history
Play 2.9 milestone
  • Loading branch information
mkurz authored Oct 10, 2022
2 parents 7f1d4dc + 2e4a271 commit 4686d67
Show file tree
Hide file tree
Showing 6 changed files with 15 additions and 8 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
uses: playframework/.github/.github/workflows/cmd.yml@v3
with:
java: 17, 11
scala: 2.12.x, 2.13.x
scala: 2.13.x
cmd: |
sbt ++$MATRIX_SCALA test
# Test sample applications
Expand Down
5 changes: 2 additions & 3 deletions project/Dependencies.scala
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,8 @@ import sbt._

object Dependencies {
// scalaVersion needs to be kept in sync with ci
val Scala212 = "2.12.17"
val Scala213 = "2.13.10"
val ScalaVersions = Seq(Scala212, Scala213)
val ScalaVersions = Seq(Scala213)

val PlayVersion = sys.props.getOrElse("play.version", sys.env.getOrElse("PLAY_VERSION", "2.8.16"))
val PlayVersion = sys.props.getOrElse("play.version", sys.env.getOrElse("PLAY_VERSION", "2.9.0-M2"))
}
2 changes: 1 addition & 1 deletion samples/compile-timeDI/build.sbt
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ ThisBuild / dynverSonatypeSnapshots := true

scalaVersion := "2.13.10"

crossScalaVersions := Seq("2.12.17", "2.13.10")
crossScalaVersions := Seq("2.13.10")

libraryDependencies ++= Seq(
"com.typesafe.play" %% "play-mailer" % version.value,
Expand Down
6 changes: 5 additions & 1 deletion samples/compile-timeDI/project/plugins.sbt
Original file line number Diff line number Diff line change
@@ -1,2 +1,6 @@
addSbtPlugin("com.typesafe.play" % "sbt-plugin" % sys.env.getOrElse("PLAY_VERSION", "2.8.16"))
lazy val plugins = (project in file(".")).settings(
scalaVersion := "2.12.17", // TODO: remove when upgraded to sbt 1.8.0
)

addSbtPlugin("com.typesafe.play" % "sbt-plugin" % sys.env.getOrElse("PLAY_VERSION", "2.9.0-M2"))
addSbtPlugin("com.dwijnand" % "sbt-dynver" % "4.1.1")
2 changes: 1 addition & 1 deletion samples/runtimeDI/build.sbt
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ ThisBuild / dynverSonatypeSnapshots := true

scalaVersion := "2.13.10"

crossScalaVersions := Seq("2.12.17", "2.13.10")
crossScalaVersions := Seq("2.13.10")

libraryDependencies ++= Seq(
"com.typesafe.play" %% "play-mailer-guice" % version.value,
Expand Down
6 changes: 5 additions & 1 deletion samples/runtimeDI/project/plugins.sbt
Original file line number Diff line number Diff line change
@@ -1,2 +1,6 @@
addSbtPlugin("com.typesafe.play" % "sbt-plugin" % sys.env.getOrElse("PLAY_VERSION", "2.8.16"))
lazy val plugins = (project in file(".")).settings(
scalaVersion := "2.12.17", // TODO: remove when upgraded to sbt 1.8.0
)

addSbtPlugin("com.typesafe.play" % "sbt-plugin" % sys.env.getOrElse("PLAY_VERSION", "2.9.0-M2"))
addSbtPlugin("com.dwijnand" % "sbt-dynver" % "4.1.1")

0 comments on commit 4686d67

Please sign in to comment.