Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Java 8 #170

Merged
merged 5 commits into from
Oct 4, 2022
Merged

Drop Java 8 #170

merged 5 commits into from
Oct 4, 2022

Conversation

mkurz
Copy link
Member

@mkurz mkurz commented Sep 29, 2022

Should be merged against a future 2.9.x branch.

Should not be necessary to replace it with MaxMetaspaceSize
since that one by default is "indefinite", and the perm size was
originally increased probably
@@ -3,5 +3,5 @@ lazy val root = (project in file(".")).
Test / test := {
val _ = (Test / g8Test).toTask("").value
},
scriptedLaunchOpts ++= List("-Xms1024m", "-Xmx1024m", "-XX:ReservedCodeCacheSize=128m", "-XX:MaxPermSize=256m", "-Xss2m", "-Dfile.encoding=UTF-8"),
scriptedLaunchOpts ++= List("-Xms1024m", "-Xmx1024m", "-XX:ReservedCodeCacheSize=128m", "-Xss2m", "-Dfile.encoding=UTF-8"),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mkurz
Copy link
Member Author

mkurz commented Sep 29, 2022

@ihostage ihostage mentioned this pull request Sep 29, 2022
30 tasks
@mkurz mkurz changed the base branch from 2.8.x to 2.9.x October 4, 2022 08:48
@mkurz mkurz marked this pull request as ready for review October 4, 2022 08:49
@mkurz mkurz mentioned this pull request Oct 4, 2022
@mkurz mkurz merged commit 80523a2 into playframework:2.9.x Oct 4, 2022
@mkurz mkurz deleted the dropJava8 branch October 4, 2022 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant