Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try Scala 3.3.1-RC4 #756

Merged
merged 2 commits into from
Jul 16, 2023
Merged

Try Scala 3.3.1-RC4 #756

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c2e7177
Try Scala 3.3.1-RC4
mkurz Jul 15, 2023
a0dea4a
hooks method should return Seq
mkurz Jul 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@ Global / onLoad := (Global / onLoad).value.andThen { s =>
lazy val commonSettings = Seq(
// Work around https://issues.scala-lang.org/browse/SI-9311
scalacOptions ~= (_.filterNot(_ == "-Xfatal-warnings")),
scalaVersion := "2.13.11", // scala213,
crossScalaVersions := Seq("2.13.11", "3.3.0"), // scala213,
pomExtra := scala.xml.NodeSeq.Empty, // Can be removed when dropping interplay
scalaVersion := "2.13.11", // scala213,
crossScalaVersions := Seq("2.13.11", "3.3.1-RC4"), // scala213,
pomExtra := scala.xml.NodeSeq.Empty, // Can be removed when dropping interplay
developers += Developer(
"playframework",
"The Play Framework Contributors",
Expand Down
4 changes: 2 additions & 2 deletions src/core/src/test/scala/play/api/db/slick/DefaultSlickApiSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ class DefaultSlickApiSpec extends Specification { self =>
// A new injector should be created to ensure each test is independent of each other
def injector: Injector = GuiceApplicationBuilder(configuration = TestData.configuration).injector()

def hooks(lifecycle: DefaultApplicationLifecycle): Array[_] = {
def hooks(lifecycle: DefaultApplicationLifecycle): Seq[_] = {
val hooksField = lifecycle.getClass.getDeclaredField("hooks")
hooksField.setAccessible(true)
hooksField.get(lifecycle).asInstanceOf[ConcurrentLinkedDeque[_]].toArray()
hooksField.get(lifecycle).asInstanceOf[ConcurrentLinkedDeque[_]].toArray().toSeq
}

"DefaultSlickApi" should {
Expand Down
Loading