Switch to GHA #215
Merged
Switch to GHA #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 tasks
mkurz
reviewed
May 16, 2022
| "scalafmtSbtCheck", | ||
| "scalafmtCheckAll", | ||
| ) ++ | ||
| List(scalaChat, scalaMultiRoomChat, scalaClusteredChat, javaChat, javaMultiRoomChat, javaClusteredChat) |
mkurz
reviewed
May 16, 2022
| apt: | ||
| packages: | ||
| - unzip | ||
| - dbus-x11 |
There was a problem hiding this comment.
Very nice the GHA VM's provide these packages.
There was a problem hiding this comment.
I'm not sure 😄 Just I migrated tests to webdrivermanager and used a headless mode
There was a problem hiding this comment.
That why now we don't need install Chrome driver manually and use X11 for tests 😄
There was a problem hiding this comment.
According to https://github.com/actions/virtual-environments/blob/ubuntu20/20220508.1/images/linux/Ubuntu2004-Readme.md there should be xvfb, unzip and dbus, however not sure about dbus-x11, maybe it's pulled in by another dep anyway. Whatever.
There was a problem hiding this comment.
That why now we don't need install Chrome driver manually and use X11 for tests 😄
mkurz
reviewed
May 16, 2022
| lazy val runChromeWebDriver = taskKey[Unit]("Run the chromewebdriver tests") | ||
|
|
||
| val macwire = "com.softwaremill.macwire" %% "macros" % "2.3.4" | ||
| val lombok = "org.projectlombok" % "lombok" % "1.18.8" | ||
| val lombok = "org.projectlombok" % "lombok" % "1.18.8" % Provided |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.