Merge pull request #323 from plivo/VT-6901

VT-6901: JWT Token Creation Issues
plivo · Nov 30, 2023 · 72389f9 · 72389f9
2 parents 9fe2f24 + ac00329
commit 72389f9
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 10 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Change Log
 
+## [v4.60.1](https://github.com/plivo/plivo-node/tree/v4.60.1) (2023-11-28)
+**Bug Fix - JWT Token Creation Issues**
+- Fix for incorrect token getting created when generated using TypeScript
+
 ## [v4.60.0](https://github.com/plivo/plivo-node/tree/v4.60.0) (2023-11-08)
 **[BETA] Feature - TollFree Verification API Support**
 - API support for Create, Update, Get, Delete and List Tollfree Verification.

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "plivo",
-  "version": "4.60.0",
+  "version": "4.60.1",
   "description": "A Node.js SDK to make voice calls and send SMS using Plivo and to generate Plivo XML",
   "homepage": "https://github.com/plivo/plivo-node",
   "files": [

diff --git a/types/resources/token.d.ts b/types/resources/token.d.ts
@@ -17,7 +17,7 @@ export class CreateTokenResponse {
 	 * @promise {object} returns Call Object
 	 * @fail {Error} returns Error
 	 */
-     create( iss: string, sub: string, nbf: number, exp: number, incoming_allow: boolean, outgoing_allow: boolean, app: string, params ? : {}): Promise < CreateTokenResponse > ;
+     create( iss: string, params ? : {}): Promise < CreateTokenResponse > ;
      /**
       * Create a token
       * @method

diff --git a/types/resources/verifyCallerId.d.ts b/types/resources/verifyCallerId.d.ts
@@ -12,7 +12,7 @@ export class VerifyCallerIdResponse {
     country:string;
     createdAt:string;
     phoneNumber:string;
-    subaccount:internal;
+    subaccount:string;
     verificationUuid:string;
 }
 
@@ -24,7 +24,7 @@ export class GetVerifiedCallerIdResponse {
     createdAt:string;
     modifiedAt:string;
     phoneNumber:string;
-    subaccount:internal;
+    subaccount:string;
     verificationUuid:string;
 }
 
@@ -54,7 +54,7 @@ export class VerifyInterface extends PlivoResourceInterface {
 
 	getVerifiedCallerId(phoneNumber: string): Promise < GetVerifiedCallerIdResponse > ;
 
-	deleteVerifiedCallerId(phoneNumber: string): Promise < > ;
+	deleteVerifiedCallerId(phoneNumber: string): Promise < any > ;
 }
 import {
   PlivoResource,

diff --git a/types/rest/client-test.d.ts b/types/rest/client-test.d.ts
@@ -18,7 +18,7 @@ export class Client {
     hostedMessagingNumber: HostedMessagingNumberInterface;
     maskingSession: MaskingSessionInterface;
     tollfreeVerification: TollfreeVerificationInterface;
-    verifyCallerId: VerifyCallerIdInterface;
+    verify: VerifyInterface;
 }
 /**
  * Plivo API client which can be used to access the Plivo APIs.
@@ -48,5 +48,5 @@ import { LOAInterface } from "../resources/loa.js";
 import { HostedMessagingNumberInterface } from "../resources/hostedMessagingNumber.js";
 import { MaskingSessionInterface } from "../resources/maskingSession.js";
 import { TollfreeVerificationInterface } from "../resources/tollfree_verification.js";
-import { VerifyCallerIdInterface } from "../resources/verifyCallerId.js";
+import { VerifyInterface } from "../resources/verifyCallerId.js";
 
diff --git a/types/rest/client.d.ts b/types/rest/client.d.ts
@@ -33,7 +33,7 @@ export class Client {
     hostedMessagingNumber: HostedMessagingNumberInterface;
     maskingSession:MaskingSessionInterface;
     tollfreeVerification: TollfreeVerificationInterface;
-    verifyCallerId:VerifyCallerIdInterface;
+    verify:VerifyInterface;
     toJSON(...args: any[]): any;
 }
 /**
@@ -70,6 +70,5 @@ import { LOAInterface } from "../resources/loa";
 import { HostedMessagingNumberInterface } from "../resources/hostedMessagingNumber";
 import { MaskingSessionInterface } from "../resources/maskingSession.js";
 import { TollfreeVerificationInterface } from "../resources/tollfree_verification.js";
-import { VerifyCallerIdInterface } from "../resources/verifyCallerId.js";
-
+import { VerifyInterface } from "../resources/verifyCallerId.js";