-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt to fix vertical padding on pixel coordinate div in imviz #4
Attempt to fix vertical padding on pixel coordinate div in imviz #4
Conversation
* attempt to fix padding inconsistencies between browsers and jupyter notebook vs lab
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The padding is fixed but "Pixel" row now jumps to the center when WCS is not present.
What do you think, @Jenneh ?
Without this patch
With this patch
Yes, that's true, it will always vertically center the contents. If we don't want that, we can add empty placeholders with a fixed height for the other "rows" so that the pixel row is always near the top. |
I don't have a preference but maybe @PatrickOgle or @Jenneh does. |
See https://vuetifyjs.com/en/components/grids/ for vuetify alignment stuff, specifically https://vuetifyjs.com/en/components/grids/#align. |
You may need to put a |
Thanks, everyone! |
It is nice that it always vertically centers. Padding looks better. It is still a little uncomfortably close to the edges but I think this is good enough for now. |
#4) * Lim edits * Improve verbiage in docstring Co-authored-by: Brett M. Morris <[email protected]> * Address review comments from bmorris3 * Add multi WCS-only test back * Update concept notebook * corrections to the pr to the pr to the pr (#10) * corrections to the pr to the pr to the pr * using app-level attr * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <[email protected]> * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <[email protected]> --------- Co-authored-by: P. L. Lim <[email protected]> * Follow up to PR to my PR to your PR * WCS-only must be loaded into viewer but not visible. Fix concept notebook --------- Co-authored-by: Brett M. Morris <[email protected]>
#4) * Lim edits * Improve verbiage in docstring Co-authored-by: Brett M. Morris <[email protected]> * Address review comments from bmorris3 * Add multi WCS-only test back * Update concept notebook * corrections to the pr to the pr to the pr (#10) * corrections to the pr to the pr to the pr * using app-level attr * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <[email protected]> * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <[email protected]> --------- Co-authored-by: P. L. Lim <[email protected]> * Follow up to PR to my PR to your PR * WCS-only must be loaded into viewer but not visible. Fix concept notebook --------- Co-authored-by: Brett M. Morris <[email protected]>
#4) * Lim edits * Improve verbiage in docstring Co-authored-by: Brett M. Morris <[email protected]> * Address review comments from bmorris3 * Add multi WCS-only test back * Update concept notebook * corrections to the pr to the pr to the pr (#10) * corrections to the pr to the pr to the pr * using app-level attr * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <[email protected]> * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <[email protected]> --------- Co-authored-by: P. L. Lim <[email protected]> * Follow up to PR to my PR to your PR * WCS-only must be loaded into viewer but not visible. Fix concept notebook --------- Co-authored-by: Brett M. Morris <[email protected]>
#4) * Lim edits * Improve verbiage in docstring Co-authored-by: Brett M. Morris <[email protected]> * Address review comments from bmorris3 * Add multi WCS-only test back * Update concept notebook * corrections to the pr to the pr to the pr (#10) * corrections to the pr to the pr to the pr * using app-level attr * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <[email protected]> * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <[email protected]> --------- Co-authored-by: P. L. Lim <[email protected]> * Follow up to PR to my PR to your PR * WCS-only must be loaded into viewer but not visible. Fix concept notebook --------- Co-authored-by: Brett M. Morris <[email protected]>
#4) * Lim edits * Improve verbiage in docstring Co-authored-by: Brett M. Morris <[email protected]> * Address review comments from bmorris3 * Add multi WCS-only test back * Update concept notebook * corrections to the pr to the pr to the pr (#10) * corrections to the pr to the pr to the pr * using app-level attr * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <[email protected]> * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <[email protected]> --------- Co-authored-by: P. L. Lim <[email protected]> * Follow up to PR to my PR to your PR * WCS-only must be loaded into viewer but not visible. Fix concept notebook --------- Co-authored-by: Brett M. Morris <[email protected]>
Description
The font that is rendered by notebook vs lab seem to be slightly different, so centering with a fixed padding is inconsistent.
This pull request attempts to give more consistent padding to the pixel display in imviz by vertically centering the div and providing a fixed line height.
Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.CHANGES.rst
?