-
-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Barceloneta based Classic UI theme #1516
Conversation
✅ Deploy Preview for 6-docs-plone-org ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hi, @petschki !
Please mention that the file that should contain the font definitions is
|
9af6515
to
53714cf
Compare
fd813ba
to
0c10cdd
Compare
I just did a merge commit to bring it inline with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly a bunch of MyST, style guide, and English syntax and grammar fixes.
Would you please take a look at moving Node.js and nvm installation to the top of the page after the introduction, and see if there is something that can be reused from existing installation documentation? Thank you!
Co-Authored-By: Steve Piercy <[email protected]>
167d7fa
to
6a19319
Compare
@stevepiercy thank you for your review. I've changed the doc and put the Node.js information at the top with a link to |
9d377de
to
12b956c
Compare
Break first subsection into two subsections. s/addon/add-on MyST and English syntax and grammar fixes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I decided it would be easier to push a commit 63b3660 with my suggestions than go through a formal review. Feel free to change them. Thank you for your contribution. This is super helpful.
|
||
|
||
(classic-ui-theming-barceloneta-theme-package-label)= | ||
|
||
## Theme package | ||
## Create a Classic UI theme addon package |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
## Create a Classic UI theme addon package | |
## Create a Classic UI theme add-on package |
This is good to merge for me 🤗 @gogobd wanted to take a second look over this. |
No description provided.