-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn this into a core addon #211
Commits on May 30, 2024
-
Turn this into a core addon, sync with CMFPlone, make installable and…
… remove old files
Configuration menu - View commit details
-
Copy full SHA for a3f9160 - Browse repository at this point
Copy the full SHA a3f9160View commit details -
Configuration menu - View commit details
-
Copy full SHA for 82328be - Browse repository at this point
Copy the full SHA 82328beView commit details -
Configuration menu - View commit details
-
Copy full SHA for ae0e9a1 - Browse repository at this point
Copy the full SHA ae0e9a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for b499f9b - Browse repository at this point
Copy the full SHA b499f9bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6378dce - Browse repository at this point
Copy the full SHA 6378dceView commit details -
Configuration menu - View commit details
-
Copy full SHA for 798e2dc - Browse repository at this point
Copy the full SHA 798e2dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 018689d - Browse repository at this point
Copy the full SHA 018689dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e74750 - Browse repository at this point
Copy the full SHA 1e74750View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8b09087 - Browse repository at this point
Copy the full SHA 8b09087View commit details -
Configuration menu - View commit details
-
Copy full SHA for 63e6fbc - Browse repository at this point
Copy the full SHA 63e6fbcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a4b393 - Browse repository at this point
Copy the full SHA 2a4b393View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ab3065 - Browse repository at this point
Copy the full SHA 9ab3065View commit details -
[pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
Configuration menu - View commit details
-
Copy full SHA for 7a806ba - Browse repository at this point
Copy the full SHA 7a806baView commit details -
Configuration menu - View commit details
-
Copy full SHA for f2f1602 - Browse repository at this point
Copy the full SHA f2f1602View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8217f26 - Browse repository at this point
Copy the full SHA 8217f26View commit details -
Configuration menu - View commit details
-
Copy full SHA for e416b70 - Browse repository at this point
Copy the full SHA e416b70View commit details
Commits on May 31, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a2f6c85 - Browse repository at this point
Copy the full SHA a2f6c85View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9981145 - Browse repository at this point
Copy the full SHA 9981145View commit details
Commits on Jun 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 99d0d0c - Browse repository at this point
Copy the full SHA 99d0d0cView commit details
Commits on Aug 13, 2024
-
[pre-commit.ci] pre-commit autoupdate
updates: - [github.com/asottile/pyupgrade: v3.15.2 → v3.16.0](asottile/pyupgrade@v3.15.2...v3.16.0) - [github.com/PyCQA/flake8: 7.0.0 → 7.1.0](PyCQA/flake8@7.0.0...7.1.0)
Configuration menu - View commit details
-
Copy full SHA for a6d7a4d - Browse repository at this point
Copy the full SHA a6d7a4dView commit details -
Test drop five:registerPackage
Is that actually needed in Plone 6?
Configuration menu - View commit details
-
Copy full SHA for c8e7340 - Browse repository at this point
Copy the full SHA c8e7340View commit details -
[pre-commit.ci] pre-commit autoupdate
updates: - [github.com/asottile/pyupgrade: v3.16.0 → v3.17.0](asottile/pyupgrade@v3.16.0...v3.17.0) - [github.com/psf/black: 24.4.2 → 24.8.0](psf/black@24.4.2...24.8.0) - [github.com/PyCQA/flake8: 7.1.0 → 7.1.1](PyCQA/flake8@7.1.0...7.1.1) - [github.com/collective/i18ndude: 6.2.0 → 6.2.1](collective/i18ndude@6.2.0...6.2.1)
Configuration menu - View commit details
-
Copy full SHA for ae39d59 - Browse repository at this point
Copy the full SHA ae39d59View commit details -
Configuration menu - View commit details
-
Copy full SHA for e66c836 - Browse repository at this point
Copy the full SHA e66c836View commit details -
Configuration menu - View commit details
-
Copy full SHA for f9c6469 - Browse repository at this point
Copy the full SHA f9c6469View commit details -
Configuration menu - View commit details
-
Copy full SHA for c5711cf - Browse repository at this point
Copy the full SHA c5711cfView commit details -
Configuration menu - View commit details
-
Copy full SHA for f896cb4 - Browse repository at this point
Copy the full SHA f896cb4View commit details -
Robot tests: install our GS profile.
I noticed that on Jenkins only 142 robot tests were run instead of 149. The console showed the reason: ``` Set up plone.app.contenttypes.testing.PloneAppContenttypes in 0.020 seconds. Set up plone.app.robotframework.testing.SimplePublicationLayer in 0.001 seconds. Set up plone.app.robotframework.remote.RemoteLibraryBundle:RobotRemote in 0.000 seconds. Set up plone.testing.zope.WSGIServer in 0.043 seconds. Set up plone.app.robotframework.testing.RemoteLibrary:Robot in 0.000 seconds. Set up plone.app.discussion.testing.PloneAppDiscussionRobot Traceback (most recent call last): File "/Users/maurits/shared-eggs/cp311/zope.testrunner-6.4-py3.11.egg/zope/testrunner/runner.py", line 474, in run_layer setup_layer(options, layer, setup_layers) File "/Users/maurits/shared-eggs/cp311/zope.testrunner-6.4-py3.11.egg/zope/testrunner/runner.py", line 839, in setup_layer setup_layer(options, base, setup_layers) File "/Users/maurits/shared-eggs/cp311/zope.testrunner-6.4-py3.11.egg/zope/testrunner/runner.py", line 844, in setup_layer layer.setUp() File "/Users/maurits/shared-eggs/cp311/plone.app.testing-7.1.0-py3.11.egg/plone/app/testing/helpers.py", line 378, in setUp self.setUpPloneSite(portal) File "/Users/maurits/community/plone-coredev/6.1/src/plone.app.discussion/plone/app/discussion/testing.py", line 111, in setUpPloneSite settings = registry.forInterface(IDiscussionSettings) File "/Users/maurits/shared-eggs/cp311/plone.registry-2.0.1-py3.11.egg/plone/registry/registry.py", line 71, in forInterface raise KeyError( KeyError: 'Interface `plone.app.discussion.interfaces.IDiscussionSettings` defines a field `globally_enabled`, for which there is no record.' ```
Configuration menu - View commit details
-
Copy full SHA for 603c903 - Browse repository at this point
Copy the full SHA 603c903View commit details -
Robot tests: we have no own keywords.robot file.
We are already loading a file with the same name from plone.app.robotframework.
Configuration menu - View commit details
-
Copy full SHA for 5ed2438 - Browse repository at this point
Copy the full SHA 5ed2438View commit details
Commits on Aug 19, 2024
-
Removed tests/dexterity_discussion.rst
This was moved here from `plone.app.dexterity`, but it has the exact same contents as `tests/functional_test_behavior_discussion.rst`. I compared again with the original in `plone.app.dexterity`, and it is indeed the same, except that the behavior name is fixed to `plone.allowdiscussion` instead of the former `plone.app.dexterity.behaviors.discussion.IAllowDiscussion`.
Configuration menu - View commit details
-
Copy full SHA for 121a256 - Browse repository at this point
Copy the full SHA 121a256View commit details -
Remove unused content_icon and content_meta_type properties from FTI.
The FTIs in `plone.app.contenttypes` do not have them.
Configuration menu - View commit details
-
Copy full SHA for da5b2f5 - Browse repository at this point
Copy the full SHA da5b2f5View commit details -
Configuration menu - View commit details
-
Copy full SHA for a8f000d - Browse repository at this point
Copy the full SHA a8f000dView commit details -
Revert "Remove unused content_icon and content_meta_type properties f…
…rom FTI." This reverts commit da5b2f5. I looked at `plone.app.contenttypes` for comparison, but those are Dexterity FTIs, and here we have an old-style FTI. When I locally added `icon_expr` in here, I actually got an error while adding a Plone Site: ``` ValueError: http://localhost:8080/@@plone-addsite Traceback (innermost last): Module ZPublisher.WSGIPublisher, line 181, in transaction_pubevents Module ZPublisher.WSGIPublisher, line 391, in publish_module Module ZPublisher.WSGIPublisher, line 285, in publish Module ZPublisher.mapply, line 98, in mapply Module ZPublisher.WSGIPublisher, line 68, in call_object Module Products.CMFPlone.browser.admin, line 299, in __call__ Module Products.CMFPlone.factory, line 165, in addPloneSite Module Products.GenericSetup.tool, line 393, in runAllImportStepsFromProfile - __traceback_info__: profile-Products.CMFPlone:plone Module Products.GenericSetup.tool, line 1513, in _runImportStepsFromContext Module Products.GenericSetup.tool, line 1360, in _doRunHandler Module Products.CMFPlone.setuphandlers, line 139, in importFinalSteps Module Products.GenericSetup.tool, line 393, in runAllImportStepsFromProfile - __traceback_info__: profile-Products.CMFPlone:dependencies Module Products.GenericSetup.tool, line 1504, in _runImportStepsFromContext Module Products.GenericSetup.tool, line 1316, in _doRunImportStep - __traceback_info__: typeinfo Module Products.CMFCore.exportimport.typeinfo, line 222, in importTypesTool Module Products.GenericSetup.utils, line 926, in importObjects - __traceback_info__: portal_types Module Products.GenericSetup.utils, line 922, in importObjects - __traceback_info__: types/Discussion_Item Module Products.GenericSetup.utils, line 525, in _importBody Module Products.CMFCore.exportimport.typeinfo, line 61, in _importNode Module Products.GenericSetup.utils, line 757, in _initProperties ValueError: undefined property 'content_icon' ``` So let's keep the old-style properties, although I am not sure they are actually used anywhere in current Plone.
Configuration menu - View commit details
-
Copy full SHA for 95d5399 - Browse repository at this point
Copy the full SHA 95d5399View commit details -
The `view` action of comments had no icon on Plone 6.
Configuration menu - View commit details
-
Copy full SHA for 473224a - Browse repository at this point
Copy the full SHA 473224aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 840a445 - Browse repository at this point
Copy the full SHA 840a445View commit details -
Register contenttype icon. Add upgrade step for updating the icons.
Update the profile version to 3000. This leaves room for upgrades on the 4.x branch (Plone 6.0).
Configuration menu - View commit details
-
Copy full SHA for ebd965c - Browse repository at this point
Copy the full SHA ebd965cView commit details
Commits on Aug 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for aa64bd1 - Browse repository at this point
Copy the full SHA aa64bd1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e32976 - Browse repository at this point
Copy the full SHA 7e32976View commit details -
Configuration menu - View commit details
-
Copy full SHA for 98aee4a - Browse repository at this point
Copy the full SHA 98aee4aView commit details