Warning-less build? #102
Closed
Warning-less build? #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So the thing is, currently the project builds with warnings. The only warnings that are there are those which are related to using Obsolete API.
There's no way in F# to suppress them locally, as it's being discussed here. I even opened a suggestion for it, but clearly it's not something we're getting soon.
So. I do prefer warning-less projects, and to enforce it, I add treating warnings as errors. However, in F# it would imply suppressing this warning for the whole file, which may accidentally hide this type of warning emitted somewhere (in other words, we exchange
false positivewithfalse negative).Thoughts?