Fix deprecated messages #822
Conversation
| @@ -39,7 +44,7 @@ def __init__( | |||
| self._download_path = download_path | |||
| self._wait_timeout = wait_timeout | |||
|
|
|||
| self._driver = self.get_webdriver(remote) | |||
| self._driver = until(lambda: self.get_webdriver(remote), timeout=1) | |||
There was a problem hiding this comment.
@alexcjohnson I change the hardcode 3x trial with the wait.until mechanism, I can try later on remove this and get more info from the logs for debugging
There was a problem hiding this comment.
Oh I see, get_webdriver swallows the error. I suppose that's OK, but the other way has the advantage that if the error persists all the way to the end it's still raised as a regular exception. perhaps build this in (optionally) to until, or make a new until variant until_no_error?
| raise | ||
| ) | ||
| except WebDriverException: | ||
| logger.exception("<<<Webdriver not initialized correctly>>>") |
There was a problem hiding this comment.
@alexcjohnson but the logger.exception will record all the exceptions, so it's not swallowed by this function. It depends on how we configure pytest, so all the logs could be accessible in the circleci.
There was a problem hiding this comment.
true, and this has the advantage that you'll actually see all the exceptions - ie if it fails 5 times you'll see all 5 - and I guess the until will ensure that at the end of it all there at least is an exception. OK, let's do it.
follow the instructions in https://docs.pytest.org/en/latest/deprecations.html#message-parameter-of-pytest-raises