Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subplot() bugfix #274

Merged
merged 2 commits into from
Aug 25, 2015
Merged

subplot() bugfix #274

merged 2 commits into from
Aug 25, 2015

Conversation

cpsievert
Copy link
Collaborator

Fixes a bug likely introduced by d4e2143.

The test shows where the bug is relevant

@chriddyp
Copy link
Member

💃

chriddyp added a commit that referenced this pull request Aug 25, 2015
@chriddyp chriddyp merged commit 3a6b9b4 into master Aug 25, 2015
@chriddyp chriddyp deleted the subplot-fix branch August 25, 2015 15:51
@cpsievert
Copy link
Collaborator Author

The message below was automatically generated after build https://travis-ci.org/ropensci/plotly/builds/77173975

On TravisCI, commit 4bb006e was successfully merged with 12c51d2 (master) to create 9531e51. A visual testing table comparing 12c51d2 with 9531e51 can be found here ->

http://cpsievert.github.io/plotly-test-table/R/9531e51/

Detected 1 differences ->

http://cpsievert.github.io/plotly-test-table/R/9531e51//plotly-subplot-group

@cpsievert
Copy link
Collaborator Author

The message below was automatically generated after build https://travis-ci.org/ropensci/plotly/builds/77176619

On TravisCI, commit 4bb006e was successfully merged with 12c51d2 (master) to create f5e4b6f. A visual testing table comparing 12c51d2 with f5e4b6f can be found here ->

http://cpsievert.github.io/plotly-test-table/R/f5e4b6f/

Detected 1 differences ->

http://cpsievert.github.io/plotly-test-table/R/f5e4b6f//plotly-subplot-group

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants