Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polar plots broken in v1.35.0 (visible on docs site) #2456

Closed
jacobq opened this issue Mar 8, 2018 · 4 comments · Fixed by #2458
Closed

Polar plots broken in v1.35.0 (visible on docs site) #2456

jacobq opened this issue Mar 8, 2018 · 4 comments · Fixed by #2458
Labels
bug something broken regression this used to work

Comments

@jacobq
Copy link

jacobq commented Mar 8, 2018

If you go to the Polar Charts in plotly.js section of the documentation (tested in Chrome 64) you will notice that the grid lines are plotted and the radial axis ticks & labels are present, but the angular axis labels and the traces are not. For example, this first codepen does not work.

Instead, an error message like the one below appears in the console. This is either a problem with plotly.js or a problem with the docs, but I can't imagine this not being a problem.

Uncaught TypeError: node.getAttribute is not a function
    at Array.d3_selectionPrototype.classed (VM456 plotly-latest.js:754)
    at ax._transfn (VM456 plotly-latest.js:173293)
    at SVGTextElement.<anonymous> (VM456 plotly-latest.js:27849)
    at VM456 plotly-latest.js:1028
    at d3_selection_each (VM456 plotly-latest.js:1034)
    at Array.d3_selectionPrototype.each (VM456 plotly-latest.js:1027)
    at positionLabels (VM456 plotly-latest.js:27845)
    at SVGTextElement.<anonymous> (VM456 plotly-latest.js:27808)
    at VM456 plotly-latest.js:1028
    at d3_selection_each (VM456 plotly-latest.js:1034)

Changing the script source to v1.34.0 seems to fix the problem, so this could be a regression introduced in v1.35.0.

@jacobq jacobq changed the title Polar plots broken on docs site Polar plots broken in v1.35.0 (visible on docs site) Mar 8, 2018
@etpinard
Copy link
Contributor

etpinard commented Mar 8, 2018

Ouch. That's bad. Not sure how that happened. Thanks for the report!

@alexcjohnson alexcjohnson added bug something broken regression this used to work labels Mar 8, 2018
@jacobq
Copy link
Author

jacobq commented Mar 8, 2018

That was quick :)

@etpinard
Copy link
Contributor

etpinard commented Mar 8, 2018

@jacobq thank you for the report! We'll try a few more things this afternoon. But we'll get our CDNs updated no later than tonight

@etpinard
Copy link
Contributor

etpinard commented Mar 9, 2018

The examples are back with 1.35.1

Thanks again @jacobq !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken regression this used to work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants