Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably not the greatest way to test those unfortunate
browser-pack-flat
hiccups, but oh well running our image tests with a pack-flat bundle would have been enough to catch #2456. This adds about 1 minute to our total test time on CI unfortunately (browser-pack-flat
is kinda slow 🐢 ). I think this is an ok compromise for now. Thoughts?Some info from my investigations:
browser-pack-flat
bundle, all image tests are passingbrowser-pack-flat
with the current configuration isn't viable. It takes more than 10 minutes to bundle plotly and the test code on CI.browser-pack-flat
. All test suites I tried were successful.exposify
so that our jasmine test suites that requirelib/index.js
grab a pack-flatbuild/plotly.js
bundle would be best.browser-pack-flat
isn't worth the trouble?