Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle with pack-flat on ci #2464

Merged
merged 1 commit into from
Mar 9, 2018
Merged

Bundle with pack-flat on ci #2464

merged 1 commit into from
Mar 9, 2018

Conversation

etpinard
Copy link
Contributor

@etpinard etpinard commented Mar 9, 2018

Probably not the greatest way to test those unfortunate browser-pack-flat hiccups, but oh well running our image tests with a pack-flat bundle would have been enough to catch #2456. This adds about 1 minute to our total test time on CI unfortunately (browser-pack-flat is kinda slow 🐢 ). I think this is an ok compromise for now. Thoughts?


Some info from my investigations:

  • I didn't find any issues (other than Polar plots broken in v1.35.0 (visible on docs site) #2456.) by flipping through the docs page
  • With the current master and a browser-pack-flat bundle, all image tests are passing
  • Running the jasmine tests with browser-pack-flat with the current configuration isn't viable. It takes more than 10 minutes to bundle plotly and the test code on CI.
  • because of ⤴️ , I couldn't get a full clean run of jasmine test working. I tested a few test suites individually with browser-pack-flat. All test suites I tried were successful.
  • Going forward, perhaps using something like exposify so that our jasmine test suites that require lib/index.js grab a pack-flat build/plotly.js bundle would be best.
  • ... but really perhaps browser-pack-flat isn't worth the trouble?

@alexcjohnson
Copy link
Collaborator

Thanks for all the investigation @etpinard - we can continue discussing pack-flat later, but for now this looks great 💃

@etpinard etpinard merged commit 0134af6 into master Mar 9, 2018
@etpinard etpinard deleted the packflat-ci-imagetests branch March 9, 2018 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants