Guard against infinite loops during scattergl line/fill positions cleanup #3199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... in scattergl positions cleanup.
|
Codepen from #3197 but using a bundle off this branch: https://codepen.io/etpinard/pen/xyvGRJ |
src/traces/scattergl/index.js
Outdated
| firstptdef += 2; | ||
| } | ||
| var lastptdef = srcPos.length - 2; | ||
| while(isNaN(srcPos[lastptdef]) || isNaN(srcPos[lastptdef + 1])) { | ||
| lastptdef += -2; | ||
| while(lastptdef > -1 && (isNaN(srcPos[lastptdef]) || isNaN(srcPos[lastptdef + 1]))) { |
There was a problem hiding this comment.
even better: while(lastptdef > firstptdef && ... would skip this second loop altogether in the failing case.
BTW do we need this pos = pos.concat... thing at all? Can't we just do lineOptions.positions = srcPos.slice(...)? It's needed in the fill section below but I don't see why it'd be needed here. In fact, even that slice seems like it could be omitted when we didn't drop any points on either end.
|
💃 |
|
Thanks for the quick review @alexcjohnson ! I'll make another patch release tomorrow morning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3197
cc @plotly/plotly_js