Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display a colorscale when scatter3d.line.showscale is set #3384

Merged
merged 6 commits into from
Jan 14, 2019

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Jan 2, 2019

Fix #2862
@plotly/plotly_js

@@ -14,7 +14,11 @@ Scatter3D.plot = require('./convert');
Scatter3D.attributes = require('./attributes');
Scatter3D.markerSymbols = require('../../constants/gl3d_markers');
Scatter3D.supplyDefaults = require('./defaults');
Scatter3D.colorbar = require('../scatter/marker_colorbar');
Scatter3D.colorbar = {
container: 'marker | line',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. That | business is a little too hacky for my taste.

Could you make this:

 Scatter3D.colorbar = [{
  container: 'marker',
  min: 'cmin',
  max: 'cmax'
}, {
  container: 'line',
  min: 'cmin',
  max: 'cmax'
}]

? Thank you!

@@ -41,19 +41,28 @@ module.exports = function connectColorbar(gd, cd, moduleOpts) {

var trace = cd[0].trace;
var cbId = 'cb' + trace.uid;
var containerName = moduleOpts.container;
var container = containerName ? trace[containerName] : trace;
var containerNames = (moduleOpts.container) ?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.... and let's make this Array.isArray(moduleOpts.container) ? ....

@etpinard
Copy link
Contributor

etpinard commented Jan 2, 2019

Thanks for taking this one! A fairly easy new feature ripe for v1.44.0.

Could you make sure to add a test mock?

@etpinard etpinard added this to the 1.44.0 milestone Jan 2, 2019
@etpinard
Copy link
Contributor

💃 - let's start merging things for 1.44.0

Nice work @archmoj !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature something new
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants