Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for <sub> and <sup> in "extra" hover label #3443

Merged
merged 6 commits into from
Jan 21, 2019
Merged

Add support for <sub> and <sup> in "extra" hover label #3443

merged 6 commits into from
Jan 21, 2019

Commits on Jan 17, 2019

  1. generalize svgTextUtils.plainText 

    - so that it can selective allow some pseudo-html tags
  to go through
- add truncate logic where allowed pseudo-html tags
  don't count toward the output "length"
    @etpinard
    etpinard committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    6226757 View commit details
    Browse the repository at this point in the history

  2. use new svgTextUtils.plainText opts for <extra> (aka name) hover label

    @etpinard
    etpinard committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    72a9915 View commit details
    Browse the repository at this point in the history

  3. tweak XSS via hover label test 

    - the malicious <img onerror=""> tag is now gone!
    @etpinard
    etpinard committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    2837ca7 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2019

  1. DRY-up hover-label alignment tests

    @etpinard
    etpinard committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    beaaf16 View commit details
    Browse the repository at this point in the history

  2. fix #3442 - consider name label height in hoverlabel y-span

    @etpinard
    etpinard committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    3d937d0 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2019

  1. add support for <b>, <i> and <em> in "name" hover labels

    @etpinard
    etpinard committed Jan 21, 2019
    Configuration menu
    Copy the full SHA
    6c7b0ed View commit details
    Browse the repository at this point in the history