Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify color attribute descriptions #366

Merged
merged 2 commits into from
Mar 30, 2016
Merged

Conversation

mdtusz
Copy link
Contributor

@mdtusz mdtusz commented Mar 30, 2016

Resolves #331

It's tricky to be crystal clear in these, but I think this gets the point across.

@cldougl @etpinard

@etpinard
Copy link
Contributor

Much better. 👍 for me

I'll let @cldougl give it another look though.

'At minimum, a mapping for the lowest (0) and highest (1)',
'values are required. For example,',
'`[[0, \'rgb(0,0,255)\', [1, \'rgb(255,0,0)\']]`.',
'To control the bounds of the colorscale in color space,',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

color space ⭐ 🌈 ⭐

@cldougl
Copy link
Member

cldougl commented Mar 30, 2016

💃 from me!
Looks much more clear!

@mdtusz mdtusz merged commit 6460fb8 into master Mar 30, 2016
@mdtusz mdtusz deleted the colorscale-descriptions branch March 30, 2016 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants