parcoords - bug fix handling undefined ranges and dticks for tickText #4011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etpinard
reviewed
Jul 3, 2019
src/traces/parcoords/defaults.js
Outdated
| @@ -55,6 +55,19 @@ function dimensionDefaults(dimensionIn, dimensionOut, parentOut, opts) { | |||
| coerce('ticktext'); | |||
| coerce('tickformat'); | |||
| var range = coerce('range'); | |||
| if(!range) { | |||
There was a problem hiding this comment.
Hmm I would move this down to the plot step. That way we don't have to loop over the data during the defaults.
There was a problem hiding this comment.
Good call.
Done in bf02101.
|
Nice fix @archmoj - I made one small comment. |
… plot - use trace._length to find extremes
|
Excellent. 💃 Sorry about those intermittent test failures. I'm working on it at the moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to some refactors (e.g. to avoid using one variable name in two scopes),
this PR fixes the
tickTextdefaults for undefined ranges and ticks to be used bytickText.Please note the changes in two baselines would make them look similar to what they look before #3966.
@plotly/plotly_js