Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add autotickangles property #6790

Merged
merged 36 commits into from
Jan 26, 2024
Merged

Add autotickangles property #6790

merged 36 commits into from
Jan 26, 2024

Commits on Nov 22, 2023

  1. drawLabels: don't attempt to re-fix label if it is already rotated by… 

    … 90 or -90 degrees.

Previously this check only tested 90 degrees.
    @my-tien
    my-tien committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    264617b View commit details
    Browse the repository at this point in the history

  2. axis autotickangles property 

    when tickangles is set to "auto", this array will be searched for the first angle large enogh to prevent overlap between labels
    @my-tien
    my-tien committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    9170f25 View commit details
    Browse the repository at this point in the history

  3. autotickangles: consider number of lines when calculating min angle

    @my-tien
    my-tien committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    eb3c456 View commit details
    Browse the repository at this point in the history

  4. Change 10.json to test autotickangles

    @my-tien
    my-tien committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    60aa918 View commit details
    Browse the repository at this point in the history

  5. autotickangles draftlog file

    @my-tien
    my-tien committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    b70ff86 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2023

  1. Achieve compatibility with ES5

    @my-tien
    my-tien committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    be99b12 View commit details
    Browse the repository at this point in the history

  2. Add noAutotickangles option for handleTickLabelDefaults calls out… 

    …side of cartesian.
    @my-tien
    my-tien committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    8ec9a45 View commit details
    Browse the repository at this point in the history

  3. drawLabels: don't assume autotickangles exists on axis.

    @my-tien
    my-tien committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    3fa1c78 View commit details
    Browse the repository at this point in the history

  4. Fix typo noAutickangles → noAutotickangles in ternay layout_defaults

    @my-tien
    my-tien committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    6d2501b View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2023

  1. Remove unnecessary coerceNumber property from autotickangles

    @my-tien
    my-tien committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    3f08ba8 View commit details
    Browse the repository at this point in the history

  2. Replace suspicious infinite loop test with check to never decrease th… 

    …e angle
    @my-tien
    my-tien committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    7ff8d92 View commit details
    Browse the repository at this point in the history

  3. Fix backwards-compatibility 

    Previously, although I used [30, 90] as default autotickangles, this did not reproduce old images, since the condition for choosing between the two was also different.
    @my-tien
    my-tien committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    9473029 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2023

  1. New 10.png baseline image for testing autotickangles

    @my-tien
    my-tien committed Nov 25, 2023
    Configuration menu
    Copy the full SHA
    4b23f99 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2023

  1. Choose angle with smallest absolute cosine instead of largest absolut… 

    …e degree value
    @my-tien
    my-tien committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    361f61b View commit details
    Browse the repository at this point in the history

  2. use info_array instead of data_array for autotickangles

    @my-tien
    my-tien committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    6d3e7bd View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2023

  1. Convert prevAngle to radians as well for calculations.

    @my-tien
    my-tien committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    896c247 View commit details
    Browse the repository at this point in the history

  2. Use the radians representation of prevAngle only for comparison (to f… 

    …ix failing tests due to floating point imprecision)
    @my-tien
    my-tien committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    aa6d492 View commit details
    Browse the repository at this point in the history

  3. For the backwards-compatible auto angle calculation also only use rad… 

    …ians representation for comparison.
    @my-tien
    my-tien committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    8ebf1a2 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2023

  1. Revert description change for tickangle because other charts reusing … 

    …the cartesian tickangle attribute don't have autotickangle.
    @my-tien
    my-tien committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    0fdf52e View commit details
    Browse the repository at this point in the history

  2. Update description in test/plot-schema.json as well.

    @my-tien
    my-tien committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    a9b9cc8 View commit details
    Browse the repository at this point in the history

  3. update plot-schema.json by running npm run schema after having starte… 

    …d the test dashboard
    @my-tien
    my-tien committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    b8a8860 View commit details
    Browse the repository at this point in the history

  4. Update draftlogs/6790_add.md 

    Co-authored-by: Mojtaba Samimi <[email protected]>
    @my-tien @archmoj
    my-tien and archmoj authored Dec 8, 2023
    Configuration menu
    Copy the full SHA
    c0e2758 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2023

  1. Revert 264617b and 7ff8d92

    @my-tien
    my-tien committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    cdae996 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2024

  1. Revert "Fix backwards-compatibility" 

    This reverts commit 9473029.
    @my-tien
    my-tien committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    80dedea View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2024

  1. Add 0 to default autotickangles array

    @my-tien
    my-tien committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    a5b1f3a View commit details
    Browse the repository at this point in the history

  2. Don't assume autotickangles exists on axis.

    @my-tien
    my-tien committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    5f3f32c View commit details
    Browse the repository at this point in the history

  3. update baseline images and plot schema

    @my-tien
    my-tien committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    f544c2a View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2024

  1. - only coerce autotickangles for x axes with auto tickangle 

    - start with the first autotickangle entry, not 0
- move radian calculation closer to its use
    @alexcjohnson
    alexcjohnson committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    7d8e607 View commit details
    Browse the repository at this point in the history

  2. fix colorbar noAutotickangles

    @alexcjohnson
    alexcjohnson committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    e20de82 View commit details
    Browse the repository at this point in the history

  3. better colorbar fix: noAutotickangles only for vertical

    @alexcjohnson
    alexcjohnson committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    4d4e056 View commit details
    Browse the repository at this point in the history

  4. allow autotickangles for polar radial axes

    @alexcjohnson
    alexcjohnson committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    84bd54b View commit details
    Browse the repository at this point in the history

  5. schema update

    @my-tien
    my-tien committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    f646c15 View commit details
    Browse the repository at this point in the history

  6. new baseline image for polar_polygon-grids with rotated axis labels

    @my-tien
    my-tien committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    1d47d05 View commit details
    Browse the repository at this point in the history

  7. fix jasmine tests

    @alexcjohnson
    alexcjohnson committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    2f6cd6f View commit details
    Browse the repository at this point in the history

  8. Update test/jasmine/tests/plots_test.js

    @archmoj
    archmoj authored Jan 26, 2024
    Configuration menu
    Copy the full SHA
    c51791e View commit details
    Browse the repository at this point in the history

  9. Update draftlogs/6790_add.md

    @archmoj
    archmoj authored Jan 26, 2024
    Configuration menu
    Copy the full SHA
    b293a11 View commit details
    Browse the repository at this point in the history