Fix JavaScript "Error: addFrames failure" in offline html export (#1152)

* Fix JavaScript `Error: addFrames failure` in offline html export
plotly · Sep 2, 2018 · 07a2ab3 · 07a2ab3
1 parent 756660a
commit 07a2ab3
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/plotly/offline/offline.py b/plotly/offline/offline.py
@@ -174,9 +174,12 @@ def _plot_html(figure_or_data, config, validate, default_width,
     jdata = _json.dumps(figure.get('data', []), cls=utils.PlotlyJSONEncoder)
     jlayout = _json.dumps(figure.get('layout', {}),
                           cls=utils.PlotlyJSONEncoder)
-    if 'frames' in figure_or_data:
-        jframes = _json.dumps(figure.get('frames', {}),
+
+    if figure.get('frames', None):
+        jframes = _json.dumps(figure.get('frames', []),
                               cls=utils.PlotlyJSONEncoder)
+    else:
+        jframes = None
 
     configkeys = (
         'staticPlot',
@@ -229,7 +232,7 @@ def _plot_html(figure_or_data, config, validate, default_width,
         config['linkText'] = link_text
         jconfig = jconfig.replace('Export to plot.ly', link_text)
 
-    if 'frames' in figure_or_data:
+    if jframes:
         script = '''
         Plotly.plot(
             '{id}',