Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show colors at the top of the gantt's colorbar #1110

Merged
merged 2 commits into from
Aug 24, 2018

Conversation

omridanan
Copy link
Contributor

When creating gantt with custom colors and there are a lot of tasks, the color legends are located at the bottom of the colorbar and not visible until the user scroll down.
This fix creates the dummy data with the colors before the data itself. This way, we still have a scroll on the colorbar, but the colors are located at the top and the user can see them immediately.

@jonmmease
Copy link
Contributor

Hi @omridanan , could you include some before and after screenshots of this change?

Looks like there are also some failing figure factory tests that would need to be updated along with this.

Thanks!

@omridanan
Copy link
Contributor Author

Sure @jonmmease

Before:
image

When you scroll down:
image

After the fix:
image

@jonmmease
Copy link
Contributor

Thanks @omridanan ,

Rather than moving the dummy legend data to the top, could we avoid displaying all of the other traces in the legend to start with? We could do this by setting the showlegend=False. This way there wouldn't be the scroll bar all.

What do you think?

@omridanan
Copy link
Contributor Author

@jonmmease works great, I'll do it.

@jonmmease
Copy link
Contributor

Hi @omridanan , could you merge master into this branch? There are some updates to the testing infrastructure that make it easier to pinpoint test failures.

@omridanan
Copy link
Contributor Author

@jonmmease seems to be fine now

@jonmmease
Copy link
Contributor

Looks good, this is a definite gantt chart improvement. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants