Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 2 iframe renderer follow-on to (#1809) #1822

Merged
merged 2 commits into from
Oct 16, 2019
Merged

Python 2 iframe renderer follow-on to (#1809) #1822

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca70962
Revert back to makedirs with exist_ok in codegen since this is alread…
jonmmease Oct 15, 2019
f7386ae
Follow the Python 3 makedirs implementation by checking isdir rather …
jonmmease Oct 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions packages/python/plotly/codegen/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,9 @@ def write_source_py(py_source, filepath, leading_newlines=0):
# Make dir if needed
# ------------------
filedir = opath.dirname(filepath)
try:
os.makedirs(filedir)
except OSError as error:
if error.errno != errno.EEXIST:
raise
# The exist_ok kwarg is only supported with Python 3, but that's ok since
# codegen is only supported with Python 3 anyway
os.makedirs(filedir, exist_ok=True)

# Write file
# ----------
Expand Down
4 changes: 2 additions & 2 deletions packages/python/plotly/plotly/io/_base_renderers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
import webbrowser
import inspect
import os
import errno
from os.path import isdir

import six
from plotly.io import to_json, to_image, write_image, write_html
Expand Down Expand Up @@ -568,7 +568,7 @@ def to_mimebundle(self, fig_dict):
try:
os.makedirs(self.html_directory)
except OSError as error:
if error.errno != errno.EEXIST:
if not isdir(self.html_directory):
raise

write_html(
Expand Down