Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sg scraper #2419

Merged
merged 5 commits into from
Apr 28, 2020
Merged

Sg scraper #2419

merged 5 commits into from
Apr 28, 2020

Conversation

emmanuelle
Copy link
Contributor

This is an improvement of the sphinx-gallery scraper, which crawls only the directory of the example and now works for different structures of galleries (I was trying to add a plotly example to the gallery of scikit-image and it did not work with the scraper, with this change it is working).

A more sustainable mid-term change would be to add a _repr_html_ method to the BaseFigure class (since the html would then be captured by sphinx-gallery) but for now the scraper works.

@emmanuelle
Copy link
Contributor Author

oops I need to fix the tests!

@nicolaskruchten
Copy link
Contributor

💃 when the tests pass, so long as this is confirmed to be a backwards-compatible change ... ?

@emmanuelle
Copy link
Contributor Author

yes this is backward-compatible! Just a less convoluted (and more robust for some galleries) way of scraping png and html files.

@emmanuelle emmanuelle merged commit 9d7b650 into master Apr 28, 2020
@nicolaskruchten
Copy link
Contributor

Oops forgot to ask for a change log item :)

@nicolaskruchten nicolaskruchten added this to the 4.7.0 milestone Apr 29, 2020
@nicolaskruchten nicolaskruchten deleted the sg_scraper branch June 19, 2020 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants