Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: customdata is sometimes a tuple #3293

Merged
merged 3 commits into from
Jul 15, 2021
Merged

Fix: customdata is sometimes a tuple #3293

merged 3 commits into from
Jul 15, 2021

Conversation

jonmmease
Copy link
Contributor

This PR is a fix for #3292

The regression was that numpy/pandas arrays with Object dtype were getting converted into Python lists when added to a Figure. This was caused by an unnecessary changed I made in the JSON serialization PR in commit 6cea61d.

This PR is largely a manual revert of that commit, with an added test to make sure serialization is still behaving properly when object arrays are included in a figure.

@nicolaskruchten
Copy link
Contributor

Thanks! Any chance that this degrades performance somehow or anything?

@jonmmease
Copy link
Contributor Author

Thanks! Any chance that this degrades performance somehow or anything?

No, I don't think so. The conversion to the tuple form would actually have been a performance hit. Serialization now has to perform the conversion, but that's what it would have needed to do before.

@nicolaskruchten
Copy link
Contributor

OK, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants