Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow non-string extras in flaglist attributes #3749

Merged
merged 5 commits into from
Jun 14, 2022

Conversation

alexcjohnson
Copy link
Collaborator

@alexcjohnson alexcjohnson commented May 26, 2022

To support plotly/plotly.js#6193

  • I have added tests (if submitting a new feature or correcting a bug) or
    modified existing tests.
  • I have added a CHANGELOG entry if fixing/changing/adding anything substantial.

@@ -286,7 +286,7 @@ def get_latest_publish_build_info(repo, branch):

url = (
r"https://circleci.com/api/v1.1/project/github/"
r"{repo}/tree/{branch}?limit=10000\&filter=completed"
r"{repo}/tree/{branch}?limit=100&filter=completed"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After I remove the \ that makes its way into the final URL but before changing the limit value, this returns:

{
  "message" : "limit must be between 0 and 100"
}

I don't know what set of jobs this was returning when the \ was there, looked recent but somehow didn't include any publish-dist jobs. 🤷 anyway now it seems to work locally.

@nicolaskruchten nicolaskruchten merged commit e962890 into master Jun 14, 2022
@alexcjohnson alexcjohnson deleted the non-string-flaglist-extras branch June 29, 2022 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants