Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #3755 Bug Fix for: Shapes and Annotations With yref Parameter Not Drawing on Correct Axis #4177

Merged
merged 23 commits into from
Jun 3, 2023
Merged

Issue #3755 Bug Fix for: Shapes and Annotations With yref Parameter Not Drawing on Correct Axis #4177

merged 23 commits into from
Jun 3, 2023

Commits on Apr 21, 2023

  1. fixed bug for issue plotly#3755 when the figure object contains subplots

    @zfoltz
    zfoltz committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    cc94803 View commit details
    Browse the repository at this point in the history

  2. fixed bug for issue plotly#3755 when the figure object does not conta… 

    …in subplots
    @zfoltz
    zfoltz committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    ebb3808 View commit details
    Browse the repository at this point in the history

  3. incorrect use of 'is' changed to '=='

    @zfoltz
    zfoltz committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    d0522f5 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2023

  1. added some conditionals to help find bug in subplot shapes

    @zfoltz
    zfoltz committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    24ad4c7 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2023

  1. fixed bug which was causing shapes to be all drawn on the same axis

    @zfoltz
    zfoltz committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    8bb24b9 View commit details
    Browse the repository at this point in the history

  2. removed some no longer needed files that were being used to find the … 

    …bug on the previous commit
    @zfoltz
    zfoltz committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    1d1db35 View commit details
    Browse the repository at this point in the history

  3. added tests

    @zfoltz
    zfoltz committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    d95d8ee View commit details
    Browse the repository at this point in the history

  4. added comments and cleaned up code

    @zfoltz
    zfoltz committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    f92dc6e View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2023

  1. more comments

    @zfoltz
    zfoltz committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    9f06509 View commit details
    Browse the repository at this point in the history

  2. removed import plotly express from test

    @zfoltz
    zfoltz committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    746b227 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2023

  1. Merge branch 'master' into axis_spanning_layout_object_xref_yref_bug

    @alexcjohnson
    alexcjohnson authored May 5, 2023
    Configuration menu
    Copy the full SHA
    336a880 View commit details
    Browse the repository at this point in the history

  2. comment tweaks and remove commented-out code

    @alexcjohnson
    alexcjohnson authored May 5, 2023
    Configuration menu
    Copy the full SHA
    9f8c92d View commit details
    Browse the repository at this point in the history

Commits on May 10, 2023

  1. Fixed issued caused by a paper or domain, yref

    @zfoltz
    zfoltz committed May 10, 2023
    Configuration menu
    Copy the full SHA
    8b2d4bf View commit details
    Browse the repository at this point in the history

  2. Merge branch 'axis_spanning_layout_object_xref_yref_bug' of https://g… 

    …ithub.com/zfoltz/plotly.py into axis_spanning_layout_object_xref_yref_bug
    @zfoltz
    zfoltz committed May 10, 2023
    Configuration menu
    Copy the full SHA
    260e3a3 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'plotly:master' into axis_spanning_layout_object_xref_yr… 

    …ef_bug
    @zfoltz
    zfoltz authored May 10, 2023
    Configuration menu
    Copy the full SHA
    ea8c795 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'axis_spanning_layout_object_xref_yref_bug' of https://g… 

    …ithub.com/zfoltz/plotly.py into axis_spanning_layout_object_xref_yref_bug
    @zfoltz
    zfoltz committed May 10, 2023
    Configuration menu
    Copy the full SHA
    a9bfd76 View commit details
    Browse the repository at this point in the history

  5. Added changelog entry

    @zfoltz
    zfoltz committed May 10, 2023
    Configuration menu
    Copy the full SHA
    872e3d5 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2023

  1. fixed issue with annotation_text of an axis_spanning_shape being disp… 

    …layed on the primary y instead of the yref supplied with the axis_spanning_shape
    @zfoltz
    zfoltz committed May 12, 2023
    Configuration menu
    Copy the full SHA
    7678812 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'axis_spanning_layout_object_xref_yref_bug' of https://g… 

    …ithub.com/zfoltz/plotly.py into axis_spanning_layout_object_xref_yref_bug
    @zfoltz
    zfoltz committed May 12, 2023
    Configuration menu
    Copy the full SHA
    cc7e200 View commit details
    Browse the repository at this point in the history

  3. Added check to catch if no yref was supplied

    @zfoltz
    zfoltz committed May 12, 2023
    Configuration menu
    Copy the full SHA
    c2860de View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into axis_spanning_layout_object_xref_yref_bug

    @zfoltz
    zfoltz authored May 12, 2023
    Configuration menu
    Copy the full SHA
    a0288c5 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2023

  1. Apply suggestions from code review

    @alexcjohnson
    alexcjohnson authored May 24, 2023
    Configuration menu
    Copy the full SHA
    a8fa9dd View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2023

  1. Merge branch 'master' into axis_spanning_layout_object_xref_yref_bug

    @alexcjohnson
    alexcjohnson authored Jun 3, 2023
    Configuration menu
    Copy the full SHA
    f5d2900 View commit details
    Browse the repository at this point in the history