style/font: use web font style #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this appears to be an internal API I think we should rather fix the warning by removing the unnecessary field instead of suppressing the warning. Or is there a reason why we need the second field? |
The second String is not used anywhere so the Rust compiler
will complain like below.
The font-style is actually useful so let's set it.
warning: field `1` is never read
-->
/home/adi/workspace/web/deps/plotters/plotters/src/style/font/web.rs:21:37
|
21 | pub struct FontDataInternal(String, String);
| ---------------- ^^^^^^
| field in this struct
|
= note: `FontDataInternal` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
= note: `#[warn(dead_code)]` on by default
help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field
|
21 | pub struct FontDataInternal(String, ());
| ~~
warning: `plotters` (lib) generated 1 warning
10ne1
force-pushed
the
dev/aratiu/silence-warning
branch
from
281d8ad
to
70b78b6
Compare
10ne1
changed the title
|
@AaronErhardt I've updated the commit, turns out we actually need that second parametr and we can set it to avoid the warning. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
style/font: use web font style
The font-style is actually useful so let's set it.