Fix histogram feature grouping on next-release-devel #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AaronErhardt I fixed the CI build on this branch, in addition to my original patch. I hope it reduces chaos just a little for you. If it's further helpful, I can commit a |
fotonick
force-pushed
the
fix_histogram_feature_grouping_2
branch
from
9995160
to
298f718
Compare
AaronErhardt
reviewed
Oct 8, 2024
Comment on lines
-96
to
+97
| fn ymd_opt(&self, year: i32, month: u32, date: u32) -> Option<Self::DateType> { | ||
| NaiveDate::from_ymd_opt(year, month, date) | ||
| fn ymd(&self, year: i32, month: u32, date: u32) -> Self::DateType { | ||
| NaiveDate::from_ymd(year, month, date) |
There was a problem hiding this comment.
I don't think this change makes sense because that would introduce a deprecated method: https://docs.rs/chrono/latest/chrono/naive/struct.NaiveDate.html#method.from_ymd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same goal as before, but since it is an API-breaking change, it is now rebased to
next-release-devel. Note that I also had to fix aPie::new()doctest that failed to compile.