Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate itemtypes without numbers; fixes #305 #306

Conversation

cedric-anne
Copy link
Contributor

@cedric-anne cedric-anne commented Mar 7, 2019

@cedric-anne cedric-anne self-assigned this Mar 7, 2019
@cedric-anne cedric-anne force-pushed the bugfix/remove-numbers-in-itemtypes branch 2 times, most recently from b392705 to 7cf05f0 Compare March 8, 2019 12:37
@cedric-anne cedric-anne marked this pull request as ready for review March 8, 2019 13:00
inc/container.class.php Outdated Show resolved Hide resolved
inc/toolbox.class.php Outdated Show resolved Hide resolved
trasher
trasher previously requested changes Mar 8, 2019
Copy link
Contributor

@trasher trasher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments. Looks good, but not tested.

@cedric-anne cedric-anne dismissed trasher’s stale review March 11, 2019 14:50

Changes were made.

@cedric-anne
Copy link
Contributor Author

@stonebuzz

I wait for your confirmation that problem is solved and migration is working well before merging this.

@cedric-anne
Copy link
Contributor Author

Fix confirmed by @stonebuzz .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants