-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate itemtypes without numbers; fixes #305 #306
Merged
cedric-anne
merged 1 commit into
pluginsGLPI:develop
from
cedric-anne:bugfix/remove-numbers-in-itemtypes
Apr 18, 2019
Merged
Generate itemtypes without numbers; fixes #305 #306
cedric-anne
merged 1 commit into
pluginsGLPI:develop
from
cedric-anne:bugfix/remove-numbers-in-itemtypes
Apr 18, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedric-anne
force-pushed
the
bugfix/remove-numbers-in-itemtypes
branch
2 times, most recently
from
March 8, 2019 12:37
b392705
to
7cf05f0
Compare
trasher
reviewed
Mar 8, 2019
trasher
reviewed
Mar 8, 2019
trasher
previously requested changes
Mar 8, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments. Looks good, but not tested.
trasher
approved these changes
Mar 12, 2019
orthagh
approved these changes
Mar 27, 2019
I wait for your confirmation that problem is solved and migration is working well before merging this. |
cedric-anne
force-pushed
the
bugfix/remove-numbers-in-itemtypes
branch
from
April 18, 2019 12:45
4c4b2bd
to
3c0d5ce
Compare
Fix confirmed by @stonebuzz . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See glpi-project/glpi#5495