Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLPI 10.0 compatibility #462

Merged
merged 11 commits into from
Apr 19, 2022
Merged

GLPI 10.0 compatibility #462

merged 11 commits into from
Apr 19, 2022

Conversation

cedric-anne
Copy link
Contributor

No description provided.

@stonebuzz
Copy link
Contributor

stonebuzz commented Dec 15, 2021

read only field seems broken (regardless of the type of container)
Only for URL type
image

@stonebuzz
Copy link
Contributor

Drag and drop icon misplaced (also while moving an element)

image

@stonebuzz
Copy link
Contributor

bad css for save button (add tab type)
image

@VladoTTX
Copy link
Contributor

VladoTTX commented Mar 4, 2022

Checked 10.0.0-rc2 with fields 1.13.0-rc2 and issue with read-only fields as reported by @stonebuzz still exist. Let me know whether I should open new issue or is it OK to report here.

I've tested all the field types.

These RO fields does not work completely:

  • Date
  • DateTime

It is possible to save them regardless of "Read Only" setting in field setup.

Issue is also with Users field. If set to RO it is not displayed in container at all but after container saving it contains value "Myself".

Also I've noticed that behavior of "Number" field changed. In 9.5.x version in allowed to enter floating point. Now it is not possible, just whole numbers are accepted, Feature or bug?

image

Also if whole container is set as Read Only for given profile some fields are editable (you are just not able to save them):

  • Text Area
  • Date
  • DateTime

- Permit installation on GLPI 10.0.x
- Replace deprecated usage of Html::autocompletionTextField()
- Fix DBmysqlIterator usage
- Fix showForm() signature
- Use same PHP minimal version as GLPI core
- Upgrade to symfony/yaml 5.4
- Remove deprecated usage of integer display width
- Use default GLPI charset/collation during install/update
- Force database dynamic row format
- Move fields display to a twig template
- Display YAML export button only on existing items, and move it in item toolbar
- ignore inactive fields
- fix warning when mandatory field is not yet initialized
@cedric-anne cedric-anne marked this pull request as ready for review April 19, 2022 13:10
@cedric-anne cedric-anne added this to the 1.14.0 milestone Apr 19, 2022
@cedric-anne cedric-anne merged commit b955476 into develop Apr 19, 2022
@cedric-anne cedric-anne deleted the feature/glpi-10.0 branch April 19, 2022 13:12
@cedric-anne cedric-anne restored the feature/glpi-10.0 branch April 19, 2022 13:37
@cedric-anne cedric-anne deleted the feature/glpi-10.0 branch April 19, 2022 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants