-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(fields): add several fields #475
Merged
cedric-anne
merged 3 commits into
pluginsGLPI:develop
from
stonebuzz:computer_switch_model
Apr 29, 2022
Merged
feat(fields): add several fields #475
cedric-anne
merged 3 commits into
pluginsGLPI:develop
from
stonebuzz:computer_switch_model
Apr 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedric-anne
reviewed
Mar 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this kind of dropdown could be added for all assets using:
$CFG_GLPI['asset_types']
to get asset classes andCommonDBTM::getModelClass()
to ensure they have a model class;- use
preg_match('/^dropdown(?<class>.+)$/', $data['type'], $matches)
to extract target class (can be used also for existingdropdownuser
anddropdownoperatingsystems
, but for this one, thes
have to be removed)
cedric-anne
force-pushed
the
feature/glpi-10.0
branch
2 times, most recently
from
March 25, 2022 10:47
c93eacf
to
4108e66
Compare
stonebuzz
force-pushed
the
computer_switch_model
branch
from
March 28, 2022 09:25
3343d3c
to
4df97c0
Compare
stonebuzz
changed the title
feat(fields): add computer / network model fields
feat(fields): add several fields
Mar 29, 2022
cedric-anne
force-pushed
the
feature/glpi-10.0
branch
4 times, most recently
from
April 5, 2022 14:22
3cdf230
to
9ac917e
Compare
cedric-anne
force-pushed
the
computer_switch_model
branch
2 times, most recently
from
April 19, 2022 12:59
ee67fbe
to
d396219
Compare
cedric-anne
force-pushed
the
feature/glpi-10.0
branch
from
April 19, 2022 13:07
9ac917e
to
ea7bb88
Compare
cedric-anne
force-pushed
the
computer_switch_model
branch
from
April 19, 2022 13:40
d396219
to
426a665
Compare
cedric-anne
force-pushed
the
computer_switch_model
branch
from
April 29, 2022 07:27
426a665
to
9415e0d
Compare
cedric-anne
approved these changes
Apr 29, 2022
cedric-anne
approved these changes
Apr 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new fields
Move old type
dropdownuser
to new onedropdownusers