Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: clone container #495

Merged
merged 1 commit into from
May 6, 2022
Merged

fix: clone container #495

merged 1 commit into from
May 6, 2022

Conversation

Rom1-B
Copy link
Contributor

@Rom1-B Rom1-B commented Apr 21, 2022

Error when cloning:

image

@Rom1-B Rom1-B requested a review from cedric-anne April 21, 2022 09:38
cedric-anne
cedric-anne requested changes Apr 29, 2022
View reviewed changes
Copy link
Contributor

@cedric-anne cedric-anne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Container is not clonable anymore in GLPI 10.0, so I guess the container class should use the Clonable trait.

@cedric-anne cedric-anne self-requested a review May 3, 2022 11:57
@cedric-anne cedric-anne self-assigned this May 3, 2022
cedric-anne
cedric-anne reviewed May 3, 2022
View reviewed changes
inc/container.class.php Outdated Show resolved Hide resolved
@cedric-anne cedric-anne requested a review from stonebuzz May 5, 2022 13:58
@cedric-anne
Copy link
Contributor

I had to fix inheritence of multiple classes to make ensure that everything is cloned correctly. I also had to fixe some side effects.

@cedric-anne cedric-anne added the bug label May 5, 2022
@cedric-anne cedric-anne added this to the 1.15.0 milestone May 5, 2022
@Rom1-B @cedric-anne
Fix container cloning
49bdaef 
 - use clone trait
 - fix classes inheritance
 - prevent automatic creation of labels and profiles on clone
@cedric-anne cedric-anne merged commit 650427e into pluginsGLPI:develop May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cedric-anne cedric-anne cedric-anne approved these changes

@stonebuzz stonebuzz Awaiting requested review from stonebuzz

Assignees

@cedric-anne cedric-anne

Labels
bug
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Rom1-B @cedric-anne