Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command: fix dropped fields #532

Conversation

AdrienClairembault
Copy link
Contributor

Internal ref: !24075.

An issue affected field removal in 1.15.0, 1.15.1 and 1.15.2.
Using these versions, removing a field from a container would drop the field from glpi_plugin_fields_fields but not from the custom container table.

This command remove these incorrectly deleted fields.

Examples:
image

@AdrienClairembault
Copy link
Contributor Author

Up @cedric-anne

@cedric-anne
Copy link
Contributor

I adapted command to make it more generic:

  • renamed to check_database
  • change option delete to fix
  • move bug details in help section

I added some colors to command ouput
image

@cedric-anne cedric-anne force-pushed the fix/fix-dropped-fields-command branch from 21d8a53 to 30361c9 Compare June 10, 2022 11:29
@cedric-anne cedric-anne merged commit bed0326 into pluginsGLPI:develop Jun 10, 2022
@AdrienClairembault
Copy link
Contributor Author

AdrienClairembault commented Jun 10, 2022

All good for me, great work 👍

I'm just not sure about "Database contains 4 gone fields" it sound of bit weird maybe ?
I think any of the following options would be a better translation :

  • The database contains 4 incorrectly deleted fields
  • The database contains 4 deleted fields
  • The database contains 4 missing fields
  • 4 incorrectly deleted fields were found in the database

Maybe @cconard96 can help us here ;)

@cconard96
Copy link
Contributor

cconard96 commented Jun 10, 2022

All of those options make it sound like something was deleted that shouldn't have been when instead, there are orphaned database fields.
It may be better to say "The database contains orphaned data from 4 previously deleted fields" or change "previously" to "improperly".

@cedric-anne cedric-anne modified the milestones: 1.15.4, 1.16.0 Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants