-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(glpi_item): add default value to prevent error when field is not filled #534
Merged
cedric-anne
merged 5 commits into
pluginsGLPI:develop
from
stonebuzz:fix_glpi_item_default_value
Jun 10, 2022
Merged
fix(glpi_item): add default value to prevent error when field is not filled #534
cedric-anne
merged 5 commits into
pluginsGLPI:develop
from
stonebuzz:fix_glpi_item_default_value
Jun 10, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stonebuzz
force-pushed
the
fix_glpi_item_default_value
branch
from
June 8, 2022 08:20
c2483a8
to
dd88c1c
Compare
AdrienClairembault
requested changes
Jun 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar tables seems to use a null value instead of an empty string, here are two examples:
CREATE TABLE `glpi_items_devicegenerics` (
`id` int(11) NOT NULL AUTO_INCREMENT,
`items_id` int(11) NOT NULL DEFAULT '0',
`itemtype` varchar(255) COLLATE utf8_unicode_ci DEFAULT NULL,
CREATE TABLE `glpi_items_problems` (
`id` int(11) NOT NULL AUTO_INCREMENT,
`problems_id` int(11) NOT NULL DEFAULT '0',
`itemtype` varchar(100) COLLATE utf8_unicode_ci DEFAULT NULL,
agree with that |
AdrienClairembault
approved these changes
Jun 8, 2022
AdrienClairembault
approved these changes
Jun 8, 2022
cedric-anne
force-pushed
the
fix_glpi_item_default_value
branch
from
June 10, 2022 11:27
2fdfc4d
to
1e27843
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add default value to prevent SQL error when field
glpi_item
is not filled