-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: make search options ID constant across profiles #593
Merged
cedric-anne
merged 5 commits into
pluginsGLPI:develop
from
btry:bugfix_search_options_id_consistency
Nov 18, 2022
Merged
Fix: make search options ID constant across profiles #593
cedric-anne
merged 5 commits into
pluginsGLPI:develop
from
btry:bugfix_search_options_id_consistency
Nov 18, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btry
force-pushed
the
bugfix_search_options_id_consistency
branch
from
November 16, 2022 08:31
af965f1
to
8cde82f
Compare
btry
commented
Nov 16, 2022
btry
force-pushed
the
bugfix_search_options_id_consistency
branch
from
November 16, 2022 08:36
8cde82f
to
4b0e630
Compare
btry
commented
Nov 16, 2022
btry
commented
Nov 16, 2022
2 tasks
cedric-anne
reviewed
Nov 16, 2022
btry
commented
Nov 16, 2022
cedric-anne
approved these changes
Nov 16, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to pluginsGLPI/formcreator#2978
Given
when Formcreator builds a search filter for a question using a field of this plugin, search options ID may vary, causing inconsistent or unexpected result when comparing the items from a profile to an other
internal ref 23137