Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check internal dependencies only before activation #2509

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Check internal dependencies only before activation #2509

wants to merge 1 commit into from

Conversation

btry
Copy link
Collaborator

@btry btry commented Dec 21, 2021 •
edited
Loading

in some cases, it may be impossible to clean, install or upgrade the plugin becausee of prerequisite checks.

@btry
fix(install): check internal dependencies only before activation
2405623 
in some cases, it may be impossible to clean, install or upgrade the plugin
@btry btry requested a review from orthagh December 21, 2021 13:06
@AdrienClairembault
Copy link
Contributor

Isn't it risky to allow installing the plugin without dependencies ?
Some upgrade code might use vendors code.

Not mandatory but if you want you can also use $plugin->isInstalled('formcreator') && !$plugin->isActivated('formcreator') as an alternative condition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orthagh orthagh Awaiting requested review from orthagh

@AdrienClairembault AdrienClairembault Awaiting requested review from AdrienClairembault

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@btry @AdrienClairembault