nest upgrade script: add more checks to deployment, remove test & get private key from env. #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eyqs
approved these changes
Nov 13, 2024
| UUPSUpgradeable private constant AGGREGATE_TOKEN_PROXY = | ||
| UUPSUpgradeable(payable(0x659619AEdf381c3739B0375082C2d61eC1fD8835)); | ||
|
|
||
| function test() public { } |
There was a problem hiding this comment.
I think we should keep the test() so it doesn't show up in forge coverage as untested?
|
|
||
| AGGREGATE_TOKEN_PROXY.upgradeToAndCall(address(newAggregateTokenImpl), ""); | ||
| console2.log("Upgrade completed successfully"); | ||
| } else { |
There was a problem hiding this comment.
It should already automatically fail because vm.startBroadcast(NEST_ADMIN_ADDRESS); will say you haven't unlocked NEST_ADMIN_ADDRESS
| vm.load( | ||
| address(AGGREGATE_TOKEN_PROXY), | ||
| // ERC1967 IMPLEMENTATION storage slot | ||
| 0x360894a13ba1a3210667c828492db98dca3e2076cc3735a920a3ca505d382bbc |
There was a problem hiding this comment.
Can you make this into a constant? bytes32(uint256(keccak256('eip1967.proxy.implementation')) - 1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ironment
What's new in this PR?
add more checks to deployment, remove test & get private key from env…
Why?
What problem does this solve?
Why is this important?
What's the context?