[NES-255] make pUSD a ComponentToken #97
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…PSUpgradeable, ComponentToken
ungaro
changed the title
eyqs
reviewed
Nov 14, 2024
…(lines&functions), fix small problems with pUSD
eyqs
approved these changes
Nov 14, 2024
| address(pUSDToken), | ||
| abi.encodeCall(pUSD.initialize, (NEST_ADMIN_ADDRESS, IERC20(USDC_ADDRESS), VAULT_ADDRESS)) | ||
| ); | ||
|
|
There was a problem hiding this comment.
Remove deploying pUSD here since we have a different script to deploy pUSD
| function convertToShares( | ||
| uint256 assets | ||
| ) public view virtual override returns (uint256) { | ||
| return _convertToShares(assets, Math.Rounding.Floor); |
There was a problem hiding this comment.
Check which should be Floor and which should be Ceil
| return _balances[account]; | ||
| } | ||
|
|
||
| function setBeforeTransferHook( |
| if (newVault == address(0)) { | ||
| revert InvalidVault(); | ||
| } | ||
|
|
There was a problem hiding this comment.
Could add supportsInterface check here for ERC-20 (imo unnecessary)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR?
make pUSD a ComponentToken.
need to have a second look and add tests..
WIP