Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the parsing of long flag strings #111

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Fix the parsing of long flag strings #111

merged 1 commit into from
Jun 12, 2024

Conversation

tgross35
Copy link
Contributor

@tgross35 tgross35 commented Jun 12, 2024

Long flag strings such as "ABCD" were getting parsed as "AA", "BB", "CC", "DD", rather than the correct "ABCD". Fix this, add a unit and integration test, and do some mild reorganization.

Should improve part of #108

Long flag strings such as "ABCD" were getting parsed as "AA", "BB",
"CC", "DD", rather than the correct "ABCD". Fix this, add a unit and
integration test, and do some mild reorganization.
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

Attention: Patch coverage is 88.39286% with 13 lines in your changes missing coverage. Please review.

Project coverage is 76.77%. Comparing base (fe17d09) to head (fdd2cc9).

Files Patch % Lines
zspell/src/dict/flags.rs 55.55% 12 Missing ⚠️
zspell/test-util/src/lib.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #111      +/-   ##
==========================================
+ Coverage   76.17%   76.77%   +0.59%     
==========================================
  Files          27       27              
  Lines        3308     3371      +63     
==========================================
+ Hits         2520     2588      +68     
+ Misses        788      783       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tgross35 tgross35 merged commit 5cf21b8 into main Jun 12, 2024
14 checks passed
@tgross35 tgross35 deleted the long-flags branch June 12, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant