Erreur 404 lorsqu'un paramètre est inconnu dans l'URI #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
de la page HTML. Evite erreur 404 inadéquate ! voir discussion https://forum.pluxml.org/viewtopic.php?id=6336 le "merge" en automatique dans la branche echecs ne passe pas (pb commit pour la fonction PlxShow::prechauffage() )
haruka-7
changed the title
haruka-7
requested changes
Nov 12, 2018
There was a problem hiding this comment.
Je confirme l'anomalie en 5.6 et en 5.7 (avec et sans le plugin plxMyBetterUrls).
@bazooka07, deux remarques :
-
Pourquoi ajouter "telechargement|download" dans le test ?
-
Afin d'harmonizer l'indentation avec le reste du code, peux-tu mettre tout le test sur une seule ligne et remplacer le "or" par "OR", stp ?
elseif(empty($this->get) OR preg_match('@^(blog|blog\/page[0-9]*|\/?page[0-9]*)$@', $this->get) OR !preg_match('@^(?:article|static|categorie|archives|tag|preview|telechargement|download)[\b\d/]+@', $this->get)) {
|
Les tests sur "telechargement|download" sont faits plus loin dans cette fonction. Mettre tous ces tests sur la même ligne va dépasser allégrment les 80 colonnes. Pas facile pour maintenir le code. |
haruka-7
pushed a commit
that referenced
this pull request
Dec 3, 2018
de la page HTML. Evite erreur 404 inadéquate ! voir discussion https://forum.pluxml.org/viewtopic.php?id=6336 le "merge" en automatique dans la branche echecs ne passe pas (pb commit pour la fonction PlxShow::prechauffage() ) Indentation MAJ Changelog FIX #302
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
de la page HTML. Evite erreur 404 inadéquate !
voir discussion https://forum.pluxml.org/viewtopic.php?id=6336
le "merge" en automatique dans la branche echecs ne passe pas (pb
commit pour la fonction PlxShow::prechauffage() )