Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimisation plxToken::getTokenPostMethod() et plxCapcha #406

Closed
wants to merge 1 commit into from

Conversation

kazimentou
Copy link
Contributor

Simplification pour la génération d'une chaine de caractères aléatoire basée sur la fonction str_shuffle() de PHP et mt_rand().
Il n'y a plus besoin d'utiliser une boucle for.
Donc, c'est plus rapide.

@haruka-7
Copy link
Collaborator

Merged in master (PluXml 5.8.3).

@kazimentou je me suis permis de retirer les underscores dans les noms des variables privées de plxCapcha pour respecter le standard PSR-12 : "Property names MUST NOT be prefixed with a single underscore to indicate protected or private visibility. That is, an underscore prefix explicitly has no meaning." (https://www.php-fig.org/psr/psr-12/#43-properties-and-constants)

@haruka-7 haruka-7 closed this Apr 17, 2020
@haruka-7 haruka-7 added this to the PluXml 5.8.3 milestone Apr 17, 2020
@haruka-7 haruka-7 added the changes new features label Apr 17, 2020
@bazooka07
Copy link
Collaborator

Pas de souci.
Je ne connais pas trop la norme PSR-12. je vais y jeter un oeil.
Merci pour le lien.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants