Add direct consumer support #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dules and init args for direct consumer mode.
ono
requested changes
Oct 3, 2020
haljin
force-pushed
the
add-direct-consumer-support
branch
from
e9fac7c
to
509b520
Compare
ono
reviewed
Oct 5, 2020
ono
approved these changes
Oct 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #169 seems dead and @sircinek and I no longer work together, I decided to pick this up and finish it. This adds support for any custom consumer type as specified by
:amqp_gen_consumerand addsAMQP.DirectConsumeras an Elixir reimplementation of:amqp_direct_consumer.The reason for this change is that when we are using this library we are opening a channel per consumer. This starts an
:amqp_selective_consumerfor each of those. That consumer is a separate process leading to a structure that looks something like this:(:amqp_channel) -- (:amqp_selective_consumer) -- (OurConsumer). In rare cases whenOurConsumercrashes,:amqp_selective_consumerremains. That means the broker still sees the channel as open and continues routing messages into it. Those messages are then being lost asOurConsumerdoes not exist anymore to handle those, neither can:amqp_selective_consumerreject them.