Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[java] FP for UnusedPrivateMethod with Jakarta @PostConstruct/PreDestroy annotations #5118

Merged
merged 1 commit into from
Jul 19, 2024
Merged

[java] FP for UnusedPrivateMethod with Jakarta @PostConstruct/PreDestroy annotations #5118

merged 1 commit into from
Jul 19, 2024

Conversation

kdebski85
Copy link
Contributor

@kdebski85 kdebski85 commented Jul 15, 2024 •
edited by jsotuyod
Loading

Describe the PR

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

@jsotuyod jsotuyod changed the title [java] Do not report UnusedPrivateMethod for method annotated with @j… [java] FP for UnusedPrivateMethod with Jakarta @PostConstruct/PreDestroy annotations Jul 15, 2024
@pmd-test
Copy link

1 Message
📖 Compared to master:
This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 2 errors and 7 configuration errors.
Download full report as build artifact

Generated by 🚫 Danger

@kdebski85 kdebski85 mentioned this pull request Jul 16, 2024
Closed
@jsotuyod
Copy link
Member

This looks great! thanks!

@adangel adangel self-assigned this Jul 19, 2024
@adangel adangel added this to the 7.4.0 milestone Jul 19, 2024
@adangel adangel merged commit 9d07192 into pmd:master Jul 19, 2024
3 checks passed
adangel added a commit that referenced this pull request Jul 19, 2024
@adangel
[doc] Update release notes (#5118, #5117)
f128bd7
adangel added a commit that referenced this pull request Jul 19, 2024
@adangel
[java] FP for UnusedPrivateMethod with Jakarta @PostConstruct/PreDest…
4d2034e 
…roy annotations (#5118)

Merge pull request #5118 from kdebski85:issue-5117-unused-private-method-jakarta
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@adangel adangel

Labels
None yet
Projects
None yet
Milestone
7.4.0
Development

Successfully merging this pull request may close these issues.

[java] UnusedPrivateMethod for methods annotated with jakarta.annotation.PostConstruct or PreDestroy
4 participants
@kdebski85 @pmd-test @jsotuyod @adangel