check if window is set (when running in worker) #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That would break the current implementation of performance.now() on node. Didn't think about web workers, I'll do a PR soon. |
|
Yes, it was just a quick fix, but same issue currently exists on the cannon-es-debugger repo I’m afraid... |
|
Thanks for the heads up, I've opened #41. cannon-es-debugger should be fine, we should just upgrade its cannon-es dependency. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
Not sure if this is the right fix, but I'm currently using cannon-es in a project I'm working on and when running the physics in a worker it crashed because of the reference to the window property.
I'm not sure If the build is ok, I'm not used to working with yarn...
Ps: is there a watch option that can be used while developing the package ?