Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose number of wheels on raycast vehicle #95

Merged
merged 2 commits into from
Jun 22, 2021
Merged

Expose number of wheels on raycast vehicle #95

merged 2 commits into from
Jun 22, 2021

Conversation

wuharvey
Copy link
Member

@wuharvey wuharvey commented Jun 19, 2021 •
edited
Loading

This would be useful in https://github.com/pmndrs/racing-game.

Would need to expose in use-cannon too after landing this

@wuharvey wuharvey requested a review from drcmda June 19, 2021 21:47
@marcofugaro
Copy link
Member

Makes sense! Thanks for the PR.

Could you just remove numWheelsOnGroundTemp and just use this.numWheelsOnGround?

I'll publish on monday.

@wuharvey
Copy link
Member Author

Done, thanks for the quick turnaround!

@wuharvey
Copy link
Member Author

Sorry to pester - will this get published today?

marcofugaro
marcofugaro approved these changes Jun 22, 2021
View reviewed changes
Copy link
Member

@marcofugaro marcofugaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing it now!

@marcofugaro marcofugaro merged commit 9f21029 into pmndrs:master Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcofugaro marcofugaro marcofugaro approved these changes

@drcmda drcmda Awaiting requested review from drcmda

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wuharvey @marcofugaro